somiljain2006 commented on PR #38990: URL: https://github.com/apache/shardingsphere/pull/38990#issuecomment-4963531193
@terrymanu Thanks for the detailed review. I've addressed the reported issues in the latest revision: * Added rewrite regression coverage for qualified-owner aggregations and prepared `CASE WHEN` expressions to verify routing and parameter rewriting. * Tightened wrapper evaluation and expanded evaluator coverage for supported wrapper expressions across both memory and stream paths, including nested wrappers, duplicate derived aggregations, short-circuit behavior, fallback evaluation, and type coercion. * Isolated expression-derived aggregation metadata for scalar subqueries by using a separate aggregation map during recursive binding. * Fixed initialization of expression-derived `COUNT` aggregations for empty/no-route results and added corresponding regression tests. * Preserved result type coercion during wrapper evaluation and added assertions covering the returned Java types. * Added rewrite integration tests and updated the merger documentation to describe supported expression-derived aggregation wrappers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
