thswlsqls opened a new pull request, #39137:
URL: https://github.com/apache/shardingsphere/pull/39137
Fixes #39134.
Changes proposed in this pull request:
- Guard the empty case in `PostgreSQLArrayParameterDecoder.decodeText()`:
when the inner content of the array literal is empty, return
`Collections.emptyList()` instead of splitting.
- Fixes `StringIndexOutOfBoundsException` when binding the empty
PostgreSQL array literal `{}`, because `"".split(",")` returns `[""]` on JDK 8
and `decodeElementText("")` then runs `"".charAt(0)`.
- The fix is in the single shared method, so all seven array types
(int2/int4/int8/float4/float8/bool/string) now decode `{}` to a zero-length
array; the non-empty path is unchanged.
- Added unit tests for empty string, int4, and bool arrays.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
