thswlsqls opened a new pull request, #39140:
URL: https://github.com/apache/shardingsphere/pull/39140
Fixes #39139.
Changes proposed in this pull request:
- Decode MySQL JSON binlog string values (`decodeString`) and object keys
(`decodeKeyEntry`) with `StandardCharsets.UTF_8` instead of `new
String(byte[])`, which relies on the JVM default charset and corrupts non-ASCII
data on non-UTF-8-default JVMs.
- MySQL JSON is stored as utf8mb4 (already noted in the class Javadoc for
the STRING type); this aligns the decoder with `MySQLPacketPayload`, which
always reads bytes with an explicit charset.
- Add a `MySQLJsonValueDecoderTest` case decoding a multibyte UTF-8 key
and value (`{"名前":"café"}`) from explicit UTF-8 bytes, asserting the utf8mb4
contract. On a UTF-8-default JVM it acts as a regression/contract guard; it
also catches corruption on non-UTF-8-default JVMs.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
