thswlsqls opened a new pull request, #39151:
URL: https://github.com/apache/shardingsphere/pull/39151
Fixes #39148.
Changes proposed in this pull request:
- Add a `<#if mode=="cluster-etcd">` block to `template/pom.ftl` that adds
the `shardingsphere-cluster-mode-repository-etcd` dependency, mirroring the
existing `cluster-zookeeper` block.
- Without it, a generated `cluster-etcd` example has no repository
provider on the classpath and fails at runtime with
`ServiceProviderNotFoundException`, even though `cluster-etcd` is a supported
mode (`YamlExampleConfigurationSupportedValue.MODES`, `config.yaml`,
`template/resources/yaml/mode/cluster-etcd.ftl`).
- Uses the existing internal module
`shardingsphere-cluster-mode-repository-etcd`
(`mode/type/cluster/repository/provider/etcd`) — no new third-party dependency.
- Extend `PomTemplateTest` with etcd and zookeeper cluster-mode assertions
verifying the rendered pom contains the matching repository provider.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally (compile + apache-rat +
`PomTemplateTest`; the examples project is a standalone build without
spotless/checkstyle).
- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the Release Notes of the current development version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
