thswlsqls opened a new pull request, #39153:
URL: https://github.com/apache/shardingsphere/pull/39153
Fixes #39149.
Changes proposed in this pull request:
- Normalize the table name with `.toLowerCase()` in
`BroadcastDataNodeRuleAttribute.getDataNodesByTableName()` before looking up
`tableDataNodes`, which is keyed by lower-cased table names in the constructor.
- Aligns the method with its three sibling lookups
(`findFirstActualTable`, `findLogicTableByActualTable`,
`findActualTableByCatalog`) that already lower-case the argument, and with the
case-insensitive lookups in the Sharding and Single data node rule attributes.
- Add a unit test asserting an upper-cased table name resolves to the same
data nodes as the lower-cased name.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
