terrymanu commented on PR #39162: URL: https://github.com/apache/shardingsphere/pull/39162#issuecomment-4998764168
### Summary **Review Result: Mergeable** **Reason:** No remaining code-level blockers were found after applying the current local two-file fix on top of the PR head; CI not reviewed by request. The patch has not yet been committed or pushed to the public PR. ### Evidence - Hive error code `10007` now maps to `QUERY_FAILED` instead of incorrectly producing object-visibility recovery guidance. - The parameterized regression test now protects the corrected behavior. - [Apache Hive 4.0.1 officially defines](https://github.com/apache/hive/blob/rel/release-4.0.1/common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java#L63) error code `10007` as “Ambiguous column reference.” - The fix remains within the Hive dialect classifier boundary and does not change public APIs, SPIs, protocols, dependencies, or shared classification precedence. - Three final review passes found no additional independent issues. ### Review Details - **Review Focus:** Code Correctness Review; CI not reviewed by request. - **Reviewed Scope:** PR head `f54ae3d4f06a5456fd2fa4cad83b7047cadef3d9`, base/merge-base `a096c1ab8811116b4b491d0c1a0224d395794253`, all 48 PR files, and the current two-file working-tree fix. The GitHub and local PR file inventories match exactly. - **Local Changes:** `HiveMCPDialectSQLExceptionClassifier.java` and its parameterized test; 3 insertions and 2 deletions. - **Verification:** Spotless passed; Checkstyle passed; 41 focused Hive and shared JDBC classifier tests passed; all 660 `mcp/support` tests passed. - **Not Reviewed Scope:** GitHub Actions/CI and the live external Hive integration matrix. - **Submission State:** The fix remains uncommitted locally and is not yet included in the public PR head. - **Release Note / User Docs:** Not required; there are no configuration, migration, protocol-version, or user-operation changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
