terrymanu commented on PR #39163: URL: https://github.com/apache/shardingsphere/pull/39163#issuecomment-4999121485
### Summary **Review Result: Mergeable** No blocking code correctness issues were found. `ROLLBACK TO <savepoint>` is now normalized to `ROLLBACK TO SAVEPOINT`, keeping it consistent with the executor and response logic. ### Evidence - `MCPStatementAnalyzer` supports both syntaxes and produces the canonical `ROLLBACK TO SAVEPOINT` statement type. - The executor correctly enters the JDBC savepoint rollback flow. - The original SQL remains in `normalizedSql`, so execution records are preserved. - The corresponding analysis and invalid-input scenarios are covered. ### Review Details - Review Focus: Code Correctness Review. - Reviewed Scope: The final base/head content changes in [PR #39163](https://github.com/apache/shardingsphere/pull/39163), primarily `MCPStatementAnalyzer.java` and its tests. - The other changes listed by GitHub are historical changes already present in the PR base tree and are not part of the final content delta. - Verification: `MCPStatementAnalyzerTest` passed 101 tests; `MCPJdbcTransactionStatementExecutorTest` passed 14 tests; Spotless and Checkstyle passed. - CI not reviewed by request. - Release Note / User Docs: Not required; this is an internal MCP statement-type normalization fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
