ClaireLytt commented on PR #39131:
URL: https://github.com/apache/shardingsphere/pull/39131#issuecomment-5001654271

   @terrymanu 
   Thanks for the review. Please check the HintManager / column-label path in 
`GeneralDQLE2EIT`.
   
   * I tried multiple times, but could not reproduce the failure with:
   
   ```sql
   SELECT o.user_id, i.* FROM t_order o JOIN t_order_item i ON o.order_id = 
i.order_id WHERE o.order_id = ?
   ```
   
   * The only pattern I can reproduce reliably is:
   
   ```sql
   SELECT T.*, T.status status_new FROM t_order T WHERE T.order_id = 1000
   ```
   
   with `HintManager.setDataSourceName(...)` and label-based 
`ResultSet.getObject(...)`. 
   * This is also the SQL used in the latest public reproduction comment on 
[#28841](https://github.com/apache/shardingsphere/issues/28841), so the current 
test follows that path.
   
   * For the next commit, would you prefer that I remove the 
HintManager-related code from `GeneralDQLE2EIT`, and keep only the core fix 
plus dedicated unit/regression tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to