menghaoranss commented on PR #39170:
URL: https://github.com/apache/shardingsphere/pull/39170#issuecomment-5002536373
```markdown
### Summary
**Review Result: Mergeable**
Reason: The result is limited to code correctness. The schema matching
behavior now preserves the existing semantics for explicitly specified schemas
while using the storage-side identifier policy only for default-schema
resolution in heterogeneous database scenarios. CI was not reviewed by request.
### Evidence
- Explicitly specified schemas continue to use exact string matching,
avoiding incorrect normalization after quote information has been removed by
the DistSQL parser.
- Default schemas use the storage database’s schema identifier policy only
when the protocol and storage database types differ.
- Same-type protocol and storage scenarios retain direct map lookup and do
not resolve an identifier policy.
- The schema policy is resolved lazily and cached per storage unit during
validation.
- Tests cover:
- Heterogeneous default-schema matching with different letter case.
- Exact explicit-schema matching.
- Rejection of an explicit schema whose case does not exactly match.
- Identifier policy matching behavior.
### Review Details
- Review Focus: Code Correctness Review. CI not reviewed by request.
- Reviewed Scope: `IdentifierNormalizeEngine`,
`IdentifierNormalizeEngineTest`, `LoadSingleTableExecutor`, and
`LoadSingleTableExecutorTest` at local HEAD
`dad38461489d1def0d4ff5183e5f37b2a9b6c6b2`.
- Local Merge Base: `dad38461489d1def0d4ff5183e5f37b2a9b6c6b2`. The reviewed
target is an uncommitted working-tree diff, so no GitHub
`/pulls/{number}/files` comparison was available.
- Not Reviewed Scope: Unrelated changes under `proxy/bootstrap`,
`docs/proposals`, and local generated files.
- Verification: `IdentifierNormalizeEngineTest` and
`LoadSingleTableExecutorTest` passed. Repository Spotless and Checkstyle checks
completed successfully with exit code 0.
- Release Note / User Docs: Not required because this is an internal
metadata lookup correction without configuration, migration, or public API
usage changes.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
