terrymanu commented on PR #39177:
URL: https://github.com/apache/shardingsphere/pull/39177#issuecomment-5010717786
### Summary
**Review Result: Mergeable**
**Reason:** The reviewed candidate tree closes the acknowledgement-contract
blocker without changing production behavior. This is code-scope readiness
only. CI not reviewed by request.
### Evidence
- Migrated transaction, Savepoint, and DDL E2E assertions from removed
`message` to canonical `summary`.
- Renamed `assertTransactionMessage` to `assertTransactionSummary` for
contract clarity.
- Confirmed no remaining SQL acknowledgement consumer reads `message`.
- `spotless:apply`: passed, exit 0.
- `checkstyle:check`: passed, exit 0.
- Focused Docker verification: 33 tests passed with 0 failures, errors, or
skips:
- `SQLExecutionPayloadTest`: 17
- `ExecuteQueryTransactionE2ETest`: 3
- `ProductionMySQLSQLRuntimeE2ETest`: 11
- `ProductionPostgreSQLRuntimeE2ETest`: 2
- Full candidate review covered 126 files. Two final adversarial passes
found no additional issue.
### Review Details
- **Review Focus:** Code Correctness Review. CI not reviewed by request.
- **Reviewed Scope:** Public PR head `ce654ee004af`, base and merge-base
`6dc8994f5d4`; GitHub’s 124-file list matched the public triple-dot diff. The
candidate scope additionally covered the two adjacent MySQL/PostgreSQL E2E
files, totaling 126 files.
- **Not Reviewed Scope:** GitHub Actions, check-runs, and workflow logs.
- **Verification:** Formatting, Checkstyle, focused unit coverage, and
affected programmatic/MySQL/PostgreSQL Docker E2E paths were executed
successfully.
- **Release Note / User Docs:** No additional documentation is required for
this test-contract correction; the PR’s protocol documentation already defines
`summary` as canonical.
- **Publication State:** The three-file correction is local and has not been
committed or pushed.
### Suggested Commit Message
`Fix MCP E2E SQL acknowledgement assertions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
