terrymanu commented on PR #39178: URL: https://github.com/apache/shardingsphere/pull/39178#issuecomment-5011009097
### Summary **Review Result: Mergeable** Reason: The package refactor is consistently propagated across public contracts, consumers, ServiceLoader registrations, tests, documentation, and E2E fixtures. No runtime behavior regression or merge blocker was found. ### Evidence - Reviewed PR head [`67183b0`](https://github.com/apache/shardingsphere/commit/67183b094facfe25b5be72aa5c6e9af592857f07) against base `2486233`; GitHub and local scopes both contain 88 changed files. - All old descriptor and `MCPHandlerProvider` FQNs are absent from tracked files. - All seven provider registrations use `org.apache.shardingsphere.mcp.spi.MCPHandlerProvider`. - Non-import changes are limited to package moves, matching documentation, ServiceLoader fixture paths, and lifecycle/concurrency contracts consistent with runtime retention. - MCP was introduced after release 5.5.3 and remains unreleased in `5.5.4-SNAPSHOT`; no compatibility bridge is required for a released API. - MCP reactor tests: `BUILD SUCCESS`, zero failures and errors. - MCP E2E reactor: 476 tests, zero failures, zero errors, 105 skipped; packaged-plugin fixture coverage passed. - `git diff --check` passed. - Public discussion contained no issue comments, inline review comments, or submitted reviews requiring adjudication. ### Review Details - Review Focus: Code Correctness Review — CI not reviewed by request. - Reviewed Scope: API/SPI boundaries, package propagation, ServiceLoader discovery, handler lifecycle contract, tests, E2E fixtures, and developer documentation. - Not Reviewed Scope: GitHub Actions/check runs and unpublished external consumers. - Verification Note: A module-only E2E attempt was classified as a stale local snapshot dependency; the authoritative reactor-aligned rerun passed. - Documentation: Chinese and English MCP developer guides correctly document the new SPI registration path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
