ClaireLytt commented on PR #39179: URL: https://github.com/apache/shardingsphere/pull/39179#issuecomment-5011347353
@terrymanu Hi! Thank you for your review suggestion in pr https://github.com/apache/shardingsphere/pull/39157. Fixing all three issues in one PR would touch a lot of code and make it quite large and hard to review, so I'd prefer to split them up. This PR addresses only the first issue — I'll follow up with separate PRs for the remaining two. So, here are changes for the first P1 issue * `TableMetaData`: `@ToString(exclude = "storageUnitName")` so aggregator structural equality ignores provenance * Test: `SchemaTableMetaDataAggregatorTest.assertAggregateWithSameStructureDifferentStorageUnitNames` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
