menghaoranss commented on PR #39197:
URL: https://github.com/apache/shardingsphere/pull/39197#issuecomment-5030094716
```markdown
### Summary
**Review Result: Mergeable**
**Reason:** The identifier policies are separated at their ownership
boundaries, and the affected lookup, normalization, refresh, and index-rebuild
paths remain consistent. This result is code-scope only; CI not reviewed by
request.
### Evidence
- `DatabaseIdentifierContext` now independently owns protocol normalization,
storage normalization, and metadata matching
(`infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/identifier/DatabaseIdentifierContext.java:35`).
- `metadata-identifier-case-sensitivity` affects only metadata lookup;
protocol and storage policies continue to come from their database-specific
providers (`DatabaseIdentifierContextFactory.java:96`).
- Schema fallback normalization uses protocol semantics, while
storage-object load candidates and missing-object fallbacks use storage
semantics (`SchemaRefreshUtils.java:57`, `TableRefreshUtils.java:263`).
- Metadata matching remains centralized for schema, table, column, index,
constraint, and Single-rule lookups.
- Runtime policy refresh propagates the shared context and rebuilds
database, schema, table, column, index, and constraint indexes, preventing
stale normalized snapshots (`ShardingSphereDatabase.java:236`).
- Full-repository call-site searches found no remaining references to the
removed policy accessor or old resolver signatures.
- The changed configuration behavior does not alter configuration keys,
formats, defaults, dependencies, packaging, or distribution artifacts.
### Review Details
- **Review Focus:** Code Correctness Review. CI not reviewed by request.
- **Reviewed Scope:** All 21 authoritative changed files across
`infra/common`, `kernel/single/core`, `mode/core`, and `mcp/support`; latest
head `8aec10f47608cf819739c239c3dd2714c7ea37e6`; base and local merge-base
`6621687546488d654546b2c8a9f8bfd66cd12dfc`. The local triple-dot file list
matched GitHub `/pulls/39197/files`.
- **Not Reviewed Scope:** GitHub Actions/CI and all MCP-related E2E, as
requested. Unrelated modules were inspected only for call-site and
compatibility impact.
- **Verification:**
- `./mvnw -pl infra/common,kernel/single/core,mode/core,mcp/support ...
test -Pcheck -T1C` — exit 0; 538 relevant tests passed: infra/common 462,
single/core 42, mode/core 28, mcp/support 6. No MCP E2E was run.
- `./mvnw -pl infra/common,kernel/single/core,mode/core,mcp/support
spotless:check checkstyle:check -Pcheck -T1C` — exit 0.
- PR metadata, files, commits, comments, and reviews endpoints were
accessible; no required public-evidence endpoint was unavailable.
- **Release Note / User Docs:** Not required. This is an internal correction
that aligns implementation with the existing documented metadata-only
configuration meaning and introduces no user-facing configuration or migration
change.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
