thswlsqls commented on PR #39097: URL: https://github.com/apache/shardingsphere/pull/39097#issuecomment-5030851260
Thanks for the review. Agreed — `getColumnMetaDataSQL` already switches to a no-predicate variant when the table collection is empty, but the view SQL always applied `table_name IN (%s)`. Fixed by splitting the view SQL the same way (`VIEW_META_DATA_SQL_WITHOUT_TABLES` / `WITH_TABLES`), and the "without tables" test now returns a view row and asserts `TableType.VIEW`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
