thswlsqls commented on PR #39098: URL: https://github.com/apache/shardingsphere/pull/39098#issuecomment-5030854781
Agreed, this is superseded. `getIfNullFunctionName()` has no production caller — the binder path (`ColumnSegmentBinder`) reads `getUnparenthesizedFunctionNames()` instead — and merged #39113 removed the method from `DialectFunctionOption` and every dialect. On current master `getIfNullFunctionName` no longer exists, so this change would only revive dead code. Closing this PR and #39096 as superseded by #39113. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
