terrymanu commented on PR #39214: URL: https://github.com/apache/shardingsphere/pull/39214#issuecomment-5046704960
### Summary **Review Result: Mergeable** Reason: The latest PR is code-scope ready. It changes only `AGENTS.md`, consolidates duplicated guidance, and adds the requested reference-first, boundary-validation, and code-economy rules without changing production behavior. CI was not reviewed by request. ### Evidence - The PR’s latest head is `603b63e289aed03272a890ffda773c537aaf014f`, with one changed file and `+34/-80` lines, matching the local triple-dot scope shown by [PR #39214](https://github.com/apache/shardingsphere/pull/39214). - The new [code-economy rule](https://github.com/apache/shardingsphere/blob/603b63e289aed03272a890ffda773c537aaf014f/AGENTS.md#L31), [validation discipline](https://github.com/apache/shardingsphere/blob/603b63e289aed03272a890ffda773c537aaf014f/AGENTS.md#L55), and [reference-first implementation rule](https://github.com/apache/shardingsphere/blob/603b63e289aed03272a890ffda773c537aaf014f/AGENTS.md#L173) directly cover the stated requirements. - Existing compatibility exceptions remain covered, including `ShardingSpherePreconditions`, public or overridden `throws` contracts, Javadoc baselines, collection snapshots, SPI behavior, and test-only production changes. - No production classes, public APIs, SPI contracts, database dialect implementations, runtime state, dependencies, or tests were changed. - Local verification on the PR head passed: - `./mvnw spotless:apply -Pcheck -T1C` - `./mvnw checkstyle:check -Pcheck -T1C` with 0 Checkstyle violations ### Review Details - Review Focus: Code Correctness Review; CI not reviewed by request. - Reviewed Scope: `AGENTS.md`; head `603b63e289aed03272a890ffda773c537aaf014f`; base and merge-base `f212965339d97b88ca59277e7bf809868ba0ffc9`; local file list matches the GitHub-reported single-file scope. - Not Reviewed Scope: GitHub Actions/check-run status and runtime product behavior; neither is relevant to this documentation-only change. - Verification: Spotless passed; Checkstyle passed with 0 violations; final diff contains only `AGENTS.md`. - Release Note / User Docs: Not required. This updates internal AI development guidance and does not change user-facing product behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
