terrymanu commented on PR #39230: URL: https://github.com/apache/shardingsphere/pull/39230#issuecomment-5066705608
### Summary **Review Result: Mergeable** The two-file patch correctly addresses the MCP E2E failures: it parses the conformance runner’s indented scenario list and restores the test-scoped Hive JDBC dependency. No code-scope blockers found. CI not reviewed by request. ### Evidence - `sed` now matches the pinned conformance runner’s actual ` - scenario` output. - `hive-jdbc` is correctly test-scoped and version-managed by the root POM. - Local `./mvnw -pl test/e2e/mcp -am test-compile ...` completed successfully. - No public review comments or unresolved discussion were present. ### Review Details - Focus: Code Correctness Review - Reviewed head: `c49de298d17f32fd5a6851b9b5baf348e61b86df` - Base / merge-base: `1f1aa6d766d031da6fd911c04654fdaf31b8ee90` - Changed-file match: confirmed; 2 files changed - Not reviewed: GitHub Actions execution and CI results - Release note/user docs: not required; changes are limited to E2E workflow parsing and test dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
