terrymanu commented on PR #39235:
URL: https://github.com/apache/shardingsphere/pull/39235#issuecomment-5068862119
### Summary
**Review Result: Mergeable**
**Reason:** The code scope of PR #39235, together with the current workspace
fixes, has passed review. No remaining code-level blockers were found. CI not
reviewed by request.
### Evidence
- Restored the established metadata detail response contract for
`logical-database`, `logical-table`, `storage-unit`, and `single-table`.
- Restored the established metadata search result contract for `database`,
`table`, and `storage-unit`.
- Added direct regression tests for metadata detail navigation and search
resource URIs.
- Verification passed:
- Spotless apply/check
- Repository-wide Checkstyle
- 6 focused tests
- Complete MCP reactor tests
- 20 MCP E2E support tests
- Completed full-coverage review of all 66 PR files. Two subsequent
adversarial review passes found no additional issues.
### Review Details
Changed files:
-
[MetadataResourceResponseFactory.java](/Users/zhangliang/IdeaProjects/shardingsphere/mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/resource/handler/metadata/MetadataResourceResponseFactory.java:276)
-
[MetadataSearchResourceUriFactory.java](/Users/zhangliang/IdeaProjects/shardingsphere/mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/tool/handler/metadata/MetadataSearchResourceUriFactory.java:119)
-
[MetadataResourceResponseFactoryTest.java](/Users/zhangliang/IdeaProjects/shardingsphere/mcp/core/src/test/java/org/apache/shardingsphere/mcp/core/resource/handler/metadata/MetadataResourceResponseFactoryTest.java:58)
-
[MetadataSearchResourceUriFactoryTest.java](/Users/zhangliang/IdeaProjects/shardingsphere/mcp/core/src/test/java/org/apache/shardingsphere/mcp/core/tool/handler/metadata/MetadataSearchResourceUriFactoryTest.java:29)
The public PR currently remains at
`704ffb36a5847d292a23d96df525d96642416721` and does not yet include these
uncommitted local fixes. This review result will apply to the GitHub PR after
the four changed files are committed and pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
