This is an automated email from the ASF dual-hosted git repository.
terrymanu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 5486b2be95f Remove redundant TODO comments (#39236)
5486b2be95f is described below
commit 5486b2be95f7c9f77f77abe0036f2c77fbdb825e
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Jul 24 18:42:45 2026 +0800
Remove redundant TODO comments (#39236)
---
.../shardingsphere/sqltranslator/natived/NativeSQLTranslator.java | 1 -
.../mode/repository/standalone/jdbc/JDBCRepository.java | 1 -
.../shardingsphere/test/e2e/sql/it/sql/dml/AdditionalDMLE2EIT.java | 4 ----
3 files changed, 6 deletions(-)
diff --git
a/kernel/sql-translator/provider/native/src/main/java/org/apache/shardingsphere/sqltranslator/natived/NativeSQLTranslator.java
b/kernel/sql-translator/provider/native/src/main/java/org/apache/shardingsphere/sqltranslator/natived/NativeSQLTranslator.java
index 98590f2e207..1baf47718fb 100644
---
a/kernel/sql-translator/provider/native/src/main/java/org/apache/shardingsphere/sqltranslator/natived/NativeSQLTranslator.java
+++
b/kernel/sql-translator/provider/native/src/main/java/org/apache/shardingsphere/sqltranslator/natived/NativeSQLTranslator.java
@@ -34,7 +34,6 @@ public final class NativeSQLTranslator implements
SQLTranslator {
@Override
public SQLTranslatorContext translate(final String sql, final List<Object>
parameters, final QueryContext queryContext, final DatabaseType storageType,
final ShardingSphereDatabase database,
final RuleMetaData
globalRuleMetaData) {
- // TODO
return new SQLTranslatorContext(sql, parameters);
}
diff --git
a/mode/type/standalone/repository/provider/jdbc/src/main/java/org/apache/shardingsphere/mode/repository/standalone/jdbc/JDBCRepository.java
b/mode/type/standalone/repository/provider/jdbc/src/main/java/org/apache/shardingsphere/mode/repository/standalone/jdbc/JDBCRepository.java
index b8e1260bf84..fca16a01dde 100644
---
a/mode/type/standalone/repository/provider/jdbc/src/main/java/org/apache/shardingsphere/mode/repository/standalone/jdbc/JDBCRepository.java
+++
b/mode/type/standalone/repository/provider/jdbc/src/main/java/org/apache/shardingsphere/mode/repository/standalone/jdbc/JDBCRepository.java
@@ -72,7 +72,6 @@ public final class JDBCRepository implements
StandalonePersistRepository {
} catch (final SQLException ignored) {
}
}
- // Finish TODO
}
}
diff --git
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dml/AdditionalDMLE2EIT.java
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dml/AdditionalDMLE2EIT.java
index c52e8271abc..48cc51f5c2a 100644
---
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dml/AdditionalDMLE2EIT.java
+++
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dml/AdditionalDMLE2EIT.java
@@ -106,7 +106,6 @@ class AdditionalDMLE2EIT extends BaseDMLE2EIT {
}
}
- // TODO
@Disabled("support execute update with column indexes in #23626")
@ParameterizedTest(name = "{0}", allowZeroInvocations = true)
@EnabledIf("isEnabled")
@@ -145,7 +144,6 @@ class AdditionalDMLE2EIT extends BaseDMLE2EIT {
}
}
- // TODO
@Disabled("support execute update with column names in #23626")
@ParameterizedTest(name = "{0}", allowZeroInvocations = true)
@EnabledIf("isEnabled")
@@ -266,7 +264,6 @@ class AdditionalDMLE2EIT extends BaseDMLE2EIT {
}
}
- // TODO
@Disabled("support execute with column indexes in #23626")
@ParameterizedTest(name = "{0}", allowZeroInvocations = true)
@EnabledIf("isEnabled")
@@ -307,7 +304,6 @@ class AdditionalDMLE2EIT extends BaseDMLE2EIT {
}
}
- // TODO
@Disabled("support execute with column names in #23626")
@ParameterizedTest(name = "{0}", allowZeroInvocations = true)
@EnabledIf("isEnabled")