terrymanu commented on PR #39248: URL: https://github.com/apache/shardingsphere/pull/39248#issuecomment-5099434708
### Summary **Review Result: Mergeable** No blocking correctness issues were found in the latest commit. This is a code-scope-only verdict; CI was not reviewed by request. ### Evidence - Reviewed only commit [`984fc420e3b7f7945687ebf98e900e2e5e5483de`](https://github.com/apache/shardingsphere/commit/984fc420e3b7f7945687ebf98e900e2e5e5483de) against its parent `fdc7dddcd2e2947ce6f565a6db32e9d6b6a6a046`. - The GitHub and local commit inventories match: three production files and three test files. - `QueryHeaderBuilderEngine` builds the header first and appends protocol attributes before publication. Metadata-only and SQL Federation paths remain unchanged. - PostgreSQL performs OID lookup only for `STRUCT` columns. Non-composite columns do not access the JDBC `ResultSet`; unresolved OIDs preserve the previous empty-attribute fallback. - All repository `QueryHeaderBuilder` implementations and direct callers were checked. No in-repository SPI regression was found. - Focused verification passed: 54 tests across backend core, PostgreSQL, openGauss, MySQL, and Firebird. - `Spotless` and `Checkstyle` passed with zero violations. ### Review Details CI not reviewed by request. - **Review Focus:** Code Correctness Review - **Scope:** Latest commit only - **PR Head:** `984fc420e3b7f7945687ebf98e900e2e5e5483de` - **Latest-Commit Base:** `fdc7dddcd2e2947ce6f565a6db32e9d6b6a6a046` - **Local PR Merge Base:** `c11a89b038ac984f79c28280bcd52280f6857587` - **PR-Wide Inventory:** Fetched; `AGENTS.md` belongs to earlier commits and was excluded. - **Findings:** None - **Release Notes / User Documentation:** Not required for this internal refactoring. - **Residual Risk:** A live PostgreSQL protocol E2E test was not run; the affected behavior is covered by focused unit and connector tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
