terrymanu commented on PR #39250: URL: https://github.com/apache/shardingsphere/pull/39250#issuecomment-5100778280
### Summary **Review Result: Mergeable** Reason: The local candidate passed the code-scope review; CI was not reviewed by request. Both previously confirmed P1 issues have been fixed, and the final adversarial review found no additional required changes. ### Evidence - `.codex/harness/agents/run.py:137` rejects contamination from global `AGENTS.md` and global or repository-level `AGENTS.override.md`. - `.codex/harness/agents/run.py:251` runs Codex in an isolated temporary root containing only an exact copy of the repository’s `AGENTS.md`, and records the policy SHA-256. This follows the documented [AGENTS.md discovery](https://learn.chatgpt.com/docs/agent-configuration/agents-md) and [`codex exec`](https://learn.chatgpt.com/docs/developer-commands?surface=cli#cli-codex-exec) behavior. - `.codex/harness/agents/run.py:369` validates the baseline contract digest, duplicate IDs, and consistency between contract and result case IDs. - `.codex/harness/agents/run.py:397` rejects removed, downgraded, or modified critical cases, as well as result regressions for critical cases that passed in the baseline. - The final baseline-backed harness run passed all 17 cases with zero critical regressions. The policy and case-contract digests remained unchanged. - Input and uncached input remained at 22,758 tokens. Runtime changed from 56.547 seconds to 59.292 seconds, with no quality regression. ### Review Details - Review Focus: Code Correctness Review; CI not reviewed by request. - Reviewed Scope: `AGENTS.md`, `.codex/harness/agents/cases.toml`, and `.codex/harness/agents/run.py`; public PR head `75131feecd43f25ab4414652c84190664a87cf0e` plus the current local `run.py` fix; local merge base `6e2462907e5880b2ac0c09fef24c1b2f182609d0`. The three-file GitHub file list matched the local PR scope. - Not Reviewed Scope: GitHub CI/check runs and product runtime code, which was not touched. - Verification: - Python syntax check: exit 0 - Negative checks for baseline removal, tampering, downgrading, and instruction-source contamination: exit 0 - Full baseline comparison harness: exit 0, 17/17 passed - `./mvnw spotless:apply -Pcheck -T1C`: exit 0 - `./mvnw checkstyle:check -Pcheck -T1C`: exit 0 - `git diff --check`: exit 0 - Release Note / User Docs: No release note is required; `AGENTS.md` is itself the repository-internal guidance document changed by this PR. - Publication State: The GitHub PR head does not yet contain the current local `run.py` fix. The user must commit and push it. If the pushed changes differ from the reviewed candidate, the PR must be reviewed again. - Proposed Git commit message: `Harden Codex policy harness isolation and baseline integrity` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
