terrymanu commented on PR #39252: URL: https://github.com/apache/shardingsphere/pull/39252#issuecomment-5101532306
### Summary **Review Result: Mergeable** Reason: The latest PR head preserves the existing policy capabilities while reducing duplicated guidance. No code-level blocker was found. This is a code-scope review only; CI not reviewed by request. ### Evidence - The guide-change loop is consolidated into [`AGENTS.md:24`](https://github.com/apache/shardingsphere/blob/900472e61c1136afea961f8d0840f4e9ae189847/AGENTS.md#L24). The original trigger, capability-ledger requirement, equivalence dimensions, authorization boundary, V0 baseline, canary criteria, regression handling, metrics comparison, and stopping condition remain explicit. - Runtime triage is consolidated at [`AGENTS.md:412`](https://github.com/apache/shardingsphere/blob/900472e61c1136afea961f8d0840f4e9ae189847/AGENTS.md#L412). Routing diagnostics still require logs, metadata freshness, parser dialect, feature-rule configuration, SQL, owning module, and focused tests; generated output remains protected from edits. - The GitHub file list contains only `AGENTS.md`, matching the local `351449a4186f1db320eeb52a7a9a12c4a0abc996...900472e61c1136afea961f8d0840f4e9ae189847` scope. - The policy harness passed all 17 synthetic cases with zero critical regressions. - Spotless and Checkstyle both passed. ### Review Details - Review Focus: Code Correctness Review; CI not reviewed by request. - Reviewed Scope: `AGENTS.md`; head `900472e61c1136afea961f8d0840f4e9ae189847`; base and merge-base `351449a4186f1db320eeb52a7a9a12c4a0abc996`; local file list matched GitHub. - Not Reviewed Scope: GitHub Actions, check-runs, and CI logs. - Verification: Policy harness exit 0; 17/17 cases passed. `./mvnw spotless:check -DspotlessFiles=AGENTS.md -Pcheck -T1C` exit 0. `./mvnw checkstyle:check -Pcheck -T1C` exit 0. - Release Note / User Docs: Not required; this PR changes only Codex repository guidance and has no runtime or user-facing behavior change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
