terrymanu commented on PR #39253: URL: https://github.com/apache/shardingsphere/pull/39253#issuecomment-5101930756
### Summary **Review Result: Mergeable** This conclusion applies only to code correctness; CI not reviewed by request. After excluding `AGENTS.md`, the openGauss composite type OID resolution, propagation, and fallback logic are complete, with no code-level blockers identified. ### Evidence - `ColumnTypeOIDLoader` processes only `STRUCT` columns and delegates dialect-specific lookup through `ColumnTypeOIDResolver`. - PostgreSQL and openGauss use their respective JDBC drivers’ `BaseConnection` and `Oid` implementations. - Both Simple Query and extended Describe paths propagate the resolved OID into RowDescription. - When an OID cannot be resolved, the existing JDBC type description is preserved, so ordinary column behavior is unchanged. - The relevant resolver, loader, QueryHeader, Simple Query, and Describe tests are covered and passed locally. - An independent openGauss release-note entry for #39253 has been added to [`RELEASE-NOTES.md`](https://github.com/apache/shardingsphere/blob/1f52bfec6d29afe92edf489c4ef786238982597b/RELEASE-NOTES.md#L41). ### Review Details - **Review Focus:** Code Correctness Review - **Reviewed Scope:** Latest commit `1f52bfec6d29afe92edf489c4ef786238982597b`; both base and merge-base are `351449a4186f1db320eeb52a7a9a12c4a0abc996`. Reviewed the OID resolver, loader, QueryHeader, Simple Query, extended Describe, and test files. The GitHub files page still showed an older 18-file snapshot when retrieved; the release-note change was verified separately through the latest commit permalink. - **Not Reviewed Scope:** `AGENTS.md` (excluded by request), composite type OID handling in Binary Portal RowDescription, CI, and GitHub Actions. - **Verification:** Focused Maven tests covered 6 modules and 7 test classes; `BUILD SUCCESS`, exit code 0. - **Release Note / User Docs:** Verified; an independent openGauss release-note entry for #39253 is present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
