menghaoranss commented on PR #39255: URL: https://github.com/apache/shardingsphere/pull/39255#issuecomment-5114234917
```markdown ### Summary **Review Result: Mergeable** - **Reason:** The latest head is mergeable within the reviewed code scope. It restores provider-owned identifier semantics without introducing compatibility, architecture, or test-validity blockers. CI not reviewed by request. ### Evidence - The removed central overrides previously forced `COLUMN`, `INDEX`, and `CONSTRAINT` to quoted-insensitive behavior, masking database-provider policies. - MySQL retains its explicit case-preserving policies, while PostgreSQL/openGauss and Oracle now correctly apply their lowercase and uppercase folding rules. These behaviors match the official [PostgreSQL](https://www.postgresql.org/docs/16/sql-syntax-lexical.html), [Oracle](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/Database-Object-Names-and-Qualifiers.html), and [Firebird](https://firebirdsql.org/file/documentation/chunk/en/refdocs/fblangref50/fblangref50-structure-identifiers.html) identifier semantics. - Updated tests cover table, view, column, index, sequence, and constraint scopes, including mixed stored-case lookups across the affected database types. - No public API, SPI, dependency, configuration-key, or distribution contract changes were introduced. ### Review Details - **Review Focus:** Code Correctness Review. CI not reviewed by request. - **Reviewed Scope:** Two changed files at public head `8815aa73bea7362694af8e834dccd95307c9c94d`; merge-base `cfc9e2425f310af42c29d052d44be4c515947865`. The local diff file list matched GitHub. - **Not Reviewed Scope:** GitHub Actions/check-runs and live-database integration or E2E behavior. - **Verification:** Focused `infra/common` test command exited `0` with 372 tests and no failures. Scoped Checkstyle exited `0` with zero violations. - **Release Notes / User Documentation:** Not required; this is an internal policy-ownership correction with no user-facing migration. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
