terrymanu commented on PR #39277: URL: https://github.com/apache/shardingsphere/pull/39277#issuecomment-5128722046
### Result **Review Result: Mergeable** PR #39277 is code-scope ready. The change correctly aligns the LLM scenario prompt with the MCP recovery contract and its evaluator; no blocking correctness findings were found. ### Evidence - Reviewed public head `cce1d5dbd2a2240888ea39c538310e653c6fb205`, with the authoritative GitHub file list matching one changed file. - `test/e2e/mcp/src/test/java/org/apache/shardingsphere/test/e2e/mcp/llm/LLMHttpE2ETest.java:146` now requires following the first `next_actions` resource URI exactly. - `mcp/core/.../MetadataResourceResponseFactory.java:144` generates the parent `resource_read` recovery action for the stale table URI. - `mcp/support/.../MCPGuidancePayloadBuilder.java:73` requires following top-level `next_actions` before inventing another call. - Focused Maven test completed successfully: 4 tests skipped because Docker E2E was disabled; 0 failures. - No public review comments or challenged findings exist. ### Coverage - Behavior cluster: invalid-resource recovery test contract. - Discovery lenses completed: root cause and behavior, blast radius and contracts, tests/runtime/operations. - The changed file is test-only; no production API, protocol, configuration, dependency, or runtime behavior changes. - Local Docker-backed model execution was not available, so the actual model conversation was not exercised locally. - This was a Code Correctness Review; CI and GitHub Actions status were not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
