strongduanmu commented on PR #39280:
URL: https://github.com/apache/shardingsphere/pull/39280#issuecomment-5130193643
**Review Result: Mergeable**
Code-scope review found no remaining blocking correctness issues. The PR
is a small, focused refactor of Oracle literal projection binding and subquery
expression bound-info handling, with targeted tests for the changed behavior.
### Evidence
- Reviewed PR head: `482b1c62c2f036c96806873e671b0ba834496a41`.
- Reviewed scope: all 4 GitHub changed files, matching the local
triple-dot diff.
- Production changes reviewed:
- `SubqueryTableBindUtils` now assigns temporary-table bound info to
non-returned-column expression projections.
- `CaseWhenExpression` returned-column derivation is narrowed to cases
where all returned branches are column segments.
- `OracleProjectionIdentifierExtractor` now handles string literal
expression projection identifiers explicitly.
- Test changes reviewed:
- `SelectStatementBinderTest` covers a subquery `CASE WHEN` projection
with a literal branch and verifies both projection and `WHERE` column bound
info.
- `OracleProjectionIdentifierExtractorTest` covers Oracle string literal
projection identifier extraction.
- CI/E2E: treated as passed based on the review scope provided by the
user; GitHub Actions were not queried and local E2E was not rerun.
### Coverage
- Behavior clusters reviewed:
- Subquery expression projection bound-info propagation.
- CASE WHEN returned-column classification.
- Oracle string literal projection identifier extraction.
- Review lenses completed:
- Root cause and behavior.
- Blast radius and contracts.
- Tests, runtime assumptions, and regression coverage.
- Result scope: code correctness only. No remaining unresolved evidence
gap was found that changes the blocker set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
