terrymanu commented on PR #39287: URL: https://github.com/apache/shardingsphere/pull/39287#issuecomment-5140018583
### Result **Review Result: Mergeable** The simplification preserves existing HTTP behavior and retains explicit HTTP/STDIO coverage where transport differences matter. ### Evidence - `AbstractTransportParameterizedE2ETest.java:25-38` initializes and resets transport to HTTP, preventing STDIO state leakage between PER_CLASS test invocations. - `FunctionalityTransportCases.java:31-63` removes only redundant single-HTTP parameterization; provider arguments still match their consumers. - `MySQLReadOnlySQLE2ETest.java:90-108,131-149` retains the two genuine dual-transport scenarios. - Scoped test compilation, Spotless, Checkstyle, and `git diff --check` completed successfully. ### Coverage - Reviewed head: `f131d22f2b973c81a510e7125664dedb3bf0df2f` - Base and merge-base: `451e1a05c56a06bbe038eaf1ee483a2edae0266b` - All seven GitHub-listed files were accounted for; the public file list matched the local triple-dot scope. - Reviewed clusters: HTTP default/reset lifecycle, parameter-source simplification, HTTP-only MySQL/PostgreSQL scenarios, and retained dual-transport coverage. - Root-cause, blast-radius/contracts, tests/runtime, and final convergence passes completed with no unresolved gaps. - This is a code-scope correctness result. GitHub Actions and CI were not queried or reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
