terrymanu commented on PR #39288: URL: https://github.com/apache/shardingsphere/pull/39288#issuecomment-5140158595
### Result **Review Result: Mergeable** No blocking correctness issues found. The change maps rejected metadata-changing DDL for PostgreSQL and openGauss from fallback SQLSTATE `99999` to the standard `0A000`, consistent with the existing pre-execution validation. ### Evidence - [Transactional DDL is rejected before backend execution](https://github.com/apache/shardingsphere/blob/0813829e7faef272a51ad9aa2cca0c5ff309e421/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/connector/ProxySQLExecutor.java#L140-L158). - [The PostgreSQL exception mapper](https://github.com/apache/shardingsphere/blob/0813829e7faef272a51ad9aa2cca0c5ff309e421/database/exception/dialect/postgresql/src/main/java/org/apache/shardingsphere/database/exception/postgresql/mapper/PostgreSQLDialectExceptionMapper.java#L67-L69) returns severity `ERROR` with SQLSTATE `0A000`. - [PostgreSQL documentation](https://www.postgresql.org/docs/12/errcodes-appendix.html) defines `0A000` as `feature_not_supported`. - PostgreSQL and openGauss protocol tests cover the SQLSTATE, severity, and error message. - The English and Chinese documentation accurately describes the LOCAL/XA limitations and rejection rationale. ### Coverage - Reviewed all 10 changed files and the related execution path. - All 64 relevant unit tests passed. - CI status was not reviewed; this review covered code correctness only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
