terrymanu commented on PR #39289: URL: https://github.com/apache/shardingsphere/pull/39289#issuecomment-5142427089
### Result **Review Result: Mergeable** The latest public head resolves the credential-audit false positive caused by Boolean metadata in Mask plan artifacts and restricts each LLM scenario to an exact tool allowlist. No blocking code-correctness issues were found. ### Evidence - Reviewed head: `f97ef242eb892ab2190e3a776bc778bc176de586`; base: `9d7a10d933b16cf5b8569314d38961df62dbf11e`. - The GitHub public file list matches the local triple-dot diff: 4 files in total. - Traced each scenario through tool allowlisting, tool-definition filtering, unauthorized-tool rejection, execution, and result evaluation. All required tools are available, with no unnecessary exposure of side-effecting tools. - Ran 10 positive and negative boundary cases against the current source regex: `failures=0`. JSON `true`, `false`, and `null` metadata are excluded, while actual passwords, tokens, Bearer credentials, and JDBC URLs are still detected. - Scoped verification passed: `./mvnw -pl test/e2e/mcp -DskipTests -Dspotless.skip=true test-compile -B -ntp`, exit code `0`. ### Coverage - Fully reviewed the workflow registration, Mask planning scenario, shared conversation runner, and tool-definition factory. - Covered root cause, blast radius, shared test-harness behavior, security boundaries, test validity, runtime configuration, and convergence review. - The PR has no description, reviews, issue comments, or inline comments; requirements were derived from the title and two public commits. - This was a code-correctness review. CI status was not queried or evaluated, and the complete LLM E2E requiring Docker and an external model was not run locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
