terrymanu commented on PR #39294: URL: https://github.com/apache/shardingsphere/pull/39294#issuecomment-5143729943
### Result **Review Result: Mergeable** No further code changes are required. Keep the current commit that only removes the TODO. No additional production code or tests are needed. ### Evidence - [PR #39294](https://github.com/apache/shardingsphere/pull/39294/files) changes one file by deleting one comment and does not alter runtime behavior. - The TODO originated in [PR #28240](https://github.com/apache/shardingsphere/pull/28240) for index loading with an unquoted `T_USER` table in a single-Oracle-storage scenario. - The standard Oracle path now normalizes table names with the storage identifier policy in `SchemaMetaDataUtils.java:85-96`; `OracleIdentifierCasePolicyProvider.java:31-32` supplies the uppercase policy for unquoted identifiers. - `SchemaMetaDataUtilsTest.java:142-152` covers normalization from `t_user` to `T_USER`. Existing Oracle policy and loader tests cover their corresponding responsibilities. - The database-wide storage policy used for mixed storage units is a separate upstream issue. The preceding [PR #39202](https://github.com/apache/shardingsphere/pull/39202) also explicitly excluded heterogeneous storage from its guarantees. That issue should not expand the scope of this PR. ### Coverage - Reviewed head: `2c912a911297cdb324cd36574eeb3baa8b73c6e8` - Merge base: `16d511600103ea6986033526c9e982ec6dbda1d4` - The GitHub file list matches the local triple-dot scope: 1/1 file. - Root cause, behavior ownership, blast radius, test validity, and regression paths were reviewed. - Spotless, Checkstyle, and 25 related focused tests passed. - No confirmed blockers or unresolved evidence gaps could change the result. - This is a code-correctness result only; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
