terrymanu commented on PR #39295: URL: https://github.com/apache/shardingsphere/pull/39295#issuecomment-5145389200
### Result **Review Result: Mergeable** No blocking code-correctness issues were found. The split artifact production, restoration, and consumption paths are complete and consistent. ### Evidence - Latest PR commit: `6caae642009e0e1c336e7ee38732b3d6c438cdad`; base and merge base: `c1b22fb063cc6d683502c9bef48e95b2ae6a8d39`. - `.github/workflows/e2e-mcp.yml:87` produces separate Maven repository and distribution artifacts. The shared upload action safely handles an empty Docker image list. - Functionality downloads both artifacts; Conformance downloads only the distribution; LLM downloads the Maven repository and the separate LLM runtime image. These routes match their actual runtime dependencies. - The workflow still contains five jobs. Both split-artifact producers, all three consumer routes, and all eight composite action invocations passed structural and input-contract validation. - All references to the old `mcp-e2e-build-artifacts` artifact have been removed. YAML parsing and `git diff --check` passed. - Both upload steps run in the same producer job. If either upload fails, dependent jobs are blocked and cannot consume an incomplete artifact set. ### Coverage - Authoritative requirement: [PR #39295](https://github.com/apache/shardingsphere/pull/39295), titled “Split MCP E2E build artifacts by consumer.” No additional description, comments, or review requirements were present. - The only changed file, `.github/workflows/e2e-mcp.yml`, was fully reviewed. - The review covered MCP E2E artifact packaging, uploading, downloading, restoration, and consumer routing. - Root Cause and Behavior, Blast Radius and Contracts, Tests, Runtime, and Operations, and latest-head convergence reviews were completed. - No unresolved code-evidence or coverage gaps remain. - This result covers code correctness only; CI status was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
