terrymanu commented on PR #39297: URL: https://github.com/apache/shardingsphere/pull/39297#issuecomment-5145986353
### Result **Review Result: Mergeable** The latest public head correctly implements the PR’s Oracle collation requirements without introducing a confirmed regression. ### Evidence - [`OracleMetaDataLoader`](https://github.com/apache/shardingsphere/blob/d3ee721972e62b8f319e01550b618a9ba31b3351/database/connector/dialect/oracle/src/main/java/org/apache/shardingsphere/database/connector/oracle/metadata/data/loader/OracleMetaDataLoader.java#L147-L165) maps `_CI`, `_AI`, `_S1`, and `_S2` to case-insensitive while preserving the existing fallback for session-dependent pseudo-collations. - This matches Oracle 12.2’s documented [case-insensitive suffixes and UCA strengths](https://docs.oracle.com/en/database/oracle/oracle-database/12.2/nlspg/database-globalization-support-guide.pdf#page=135) and [pseudo-collation semantics](https://docs.oracle.com/en/database/oracle/oracle-database/12.2/nlspg/database-globalization-support-guide.pdf#page=166). - [`OracleMetaDataLoaderTest`](https://github.com/apache/shardingsphere/blob/d3ee721972e62b8f319e01550b618a9ba31b3351/database/connector/dialect/oracle/src/test/java/org/apache/shardingsphere/database/connector/oracle/metadata/data/loader/OracleMetaDataLoaderTest.java#L257-L279) exercises the public SPI path across Oracle version boundaries, null and named collations, UCA strengths, and pseudo-collations. - Focused verification completed successfully: 23 tests, 0 failures, 0 errors. ### Coverage - Head: `d3ee721972e62b8f319e01550b618a9ba31b3351` - Base and merge-base: `0008fc87eb655ef2720a49ce91e8129caf404e4f` - All 2 authoritative GitHub files were reviewed; the local triple-dot file list matched GitHub. - Behavior cluster: Oracle 12.2+ column-collation detection and downstream `ColumnMetaData.caseSensitive` behavior. - Root-cause, blast-radius/contracts, and tests/runtime/operations lenses completed. Final convergence pass found no new candidates. - Unresolved evidence gaps: none. - This is a code-scope result only; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
