terrymanu commented on PR #39318: URL: https://github.com/apache/shardingsphere/pull/39318#issuecomment-5161538863
### Result **Review Result: Mergeable** PR correctly removes the unused duplicate referenced-object-name representation without changing SQL classification, cross-schema validation, EXPLAIN handling, or MCP protocol payloads. ### Evidence - Reviewed latest head [`fe95145`](https://github.com/apache/shardingsphere/commit/fe95145a0c0aa21e0565bfbe1efff7787b6c3de1) against base `6247606`; GitHub and local triple-dot scopes both contain the same four files. - [`ClassificationResult`](https://github.com/apache/shardingsphere/blob/fe95145a0c0aa21e0565bfbe1efff7787b6c3de1/mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/tool/handler/execute/ClassificationResult.java#L31-L60) retains the authoritative structured `referencedObjects` collection while removing only its unused derived name collection and allocation. - Repository-wide production, E2E, documentation, configuration, reflection, and serialization searches found no consumer of `getReferencedObjectNames()`. - MCP payloads explicitly select fields rather than serializing `ClassificationResult`; no protocol field is removed. - Compatibility is preserved: release [`5.5.3`](https://github.com/apache/shardingsphere/releases/tag/5.5.3) predates the [initial MCP implementation](https://github.com/apache/shardingsphere/commit/c4490adbeda35f2b6f788cab5119b5a459168828), and the current version is `5.5.4-SNAPSHOT`. - Tests now project names from the authoritative objects while retaining ordering, qualification, EXPLAIN propagation, and facade-consumer assertions. - Focused verification passed: 199 tests, 0 failures, 0 errors. - `spotless:check` and `checkstyle:check` passed. ### Coverage - Reviewed head: `fe95145a0c0aa21e0565bfbe1efff7787b6c3de1`. - Requirements: PR title and complete public diff; no PR body, linked issue, review, comment, or inline thread was present. - Files accounted for: 1 production file and 3 test files. - Behavior cluster: authoritative referenced-object representation and its analyzer, EXPLAIN, and execution-facade consumers. - Completed lenses: root cause and behavior; blast radius and contracts; tests, runtime, and operations; latest-head convergence. - Unresolved evidence gaps: none. - This is a code-correctness result only; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
