menghaoranss commented on PR #39291: URL: https://github.com/apache/shardingsphere/pull/39291#issuecomment-5161829795
```markdown ### Result **Review Result: Mergeable** No code-correctness blockers were found at the reviewed public head. ### Evidence - `GenericSchemaBuilder.java:73-92` propagates the existing protocol type into metadata-material construction across all builder entry paths. - `SchemaMetaDataUtils.java:79-100` preserves exact physical table names when protocol and storage types match, while retaining storage-policy normalization for heterogeneous backends. - This restores the original same-type behavior introduced by [#38678](https://github.com/apache/shardingsphere/pull/38678) without reintroducing its all-or-nothing handling for mixed storage types. - `SchemaMetaDataUtilsTest.java:143-184` covers both branches: heterogeneous Oracle normalization and same-type PostgreSQL case preservation. - Focused `SchemaMetaDataUtilsTest` and `GenericSchemaBuilderTest`: 22 tests passed, exit 0. - Scoped `infra/common` Checkstyle: zero violations, exit 0. ### Coverage - Reviewed head: `79f1a0fd1140ed2f6d90f85c2be02e8f09ea65eb` - Base and merge-base: `66e57fbc1ad3684190c7f49028824006f36e79fc` - Requirements: PR title and description; no linked issue or public review discussion. - All three authoritative changed files were reviewed, and the local triple-dot file list matched GitHub. - Behavior clusters: protocol-type propagation; per-storage table-name normalization. - Completed lenses: root cause and behavior; blast radius and contracts; tests, runtime, and operations. - Convergence pass found zero new independent candidates. - Unresolved evidence gaps: none. - This is a code-scope result only; CI was not reviewed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
