terrymanu commented on PR #39320: URL: https://github.com/apache/shardingsphere/pull/39320#issuecomment-5164377628
### Result **Review Result: Mergeable** No blocking code-correctness issues were found in the latest public revision. ### Evidence - [`YamlRowStatisticsSwapperTest.java:89`](https://github.com/apache/shardingsphere/blob/f11c617babf0deb33dfe050ddeedc77fda3ab8fc/infra/common/src/test/java/org/apache/shardingsphere/infra/yaml/data/swapper/YamlRowStatisticsSwapperTest.java#L89) now covers the actual `NUMERIC` string restoration path. - [`YamlRowStatisticsSwapper.java:55`](https://github.com/apache/shardingsphere/blob/f11c617babf0deb33dfe050ddeedc77fda3ab8fc/infra/common/src/main/java/org/apache/shardingsphere/infra/yaml/data/swapper/YamlRowStatisticsSwapper.java#L55) follows the JDBC mappings: - `BIGINT → Long` - `REAL → Float` - `FLOAT/DOUBLE → Double` - `DECIMAL/NUMERIC → BigDecimal` - The project uses [SnakeYAML 2.2](https://github.com/apache/shardingsphere/blob/f11c617babf0deb33dfe050ddeedc77fda3ab8fc/pom.xml#L92), whose integer and floating-point construction behavior matches the current restoration logic. - The focused test suite passed on the public head: 18 tests, with no failures or errors. - Class, line, and branch coverage for the target class are all 100%. ### Coverage - Reviewed head: `f11c617babf0deb33dfe050ddeedc77fda3ab8fc` - Base branch: `master` - Merge base: `c973af5854a4f0f398a3c7bb6be1797882e3bd59` - The GitHub and local triple-dot file lists match; all 2 changed files were reviewed. - Production conversion, persisted-data compatibility, callers, performance, and parameterized-test validity were reviewed. - Root-cause, blast-radius, tests/runtime, and final convergence passes were completed with no unresolved evidence gaps. - This is a code-correctness result only; GitHub Actions and other CI checks were not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
