terrymanu commented on PR #39321: URL: https://github.com/apache/shardingsphere/pull/39321#issuecomment-5165158263
### Result **Review Result: Mergeable** No reproducible correctness blockers were found. The implementation is consistent with the PR’s goal of removing natural-language keyword inference and using structured arguments instead. ### Evidence - `natural_language_intent` is retained only as opaque context. No remaining keyword or synonym matching was found in production code. - A missing `operation_type` now triggers clarification, while fixed cleanup workflows remain drop-only. - `structured_intent_evidence`, `field_semantics`, and `reasoning_notes` were consistently removed from models, binders, payloads, and affected descriptors. - Encrypt’s three Boolean requirements were promoted to top-level structured arguments, with missing-argument and continuation scenarios covered. - Related call paths and tests for Readwrite Splitting, Mask, Sharding, Broadcast, and Shadow were updated consistently. Verification results: - Unit tests for the seven affected MCP modules: passed. - `test/e2e/mcp` test compilation: passed. - Spotless: passed. - Checkstyle: passed. ### Coverage - Reviewed PR: [apache/shardingsphere#39321](https://github.com/apache/shardingsphere/pull/39321) - Head: `3cae2593979b5e213404c899ee55f713faae7986` - Base/merge-base: `9a4d99758493212a662d241352b570786b6476bc` - The GitHub and local change scopes match: all 67 changed files were reviewed individually. - The support module, six feature modules, descriptors, unit tests, and MCP E2E test paths were reviewed. - The PR has no linked issue, public review comments, or pending public feedback. - This was a code-correctness review; CI was not inspected. Docker-based runtime E2E tests were not executed, but the related E2E sources compiled successfully and the main behavioral branches have focused test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
