terrymanu commented on PR #39324: URL: https://github.com/apache/shardingsphere/pull/39324#issuecomment-5167887872
### Result **Review Result: Mergeable** The latest public head fully resolves the alternative-input clarification and key-generator state-handling issues. No code-correctness blockers were found. ### Evidence - `ShardingWorkflowInputValidator.java:182-183` and `298-305`: Alternative input scenarios no longer mark mutually exclusive fields as simultaneously required. - `ShardingWorkflowInputValidator.java:194-211`: Named and inline key generators share state-aware validation. When `key_generator_properties` is present, only `key_generator_type` is required. - `ShardingWorkflowPlanningServiceTest.java:102-127` and `278-330`: Tests cover all three alternative-input clarifications, continuation with the same `plan_id`, property preservation, and successful planning. - Current-source reactor verification passed: 899 tests, 0 failures. ### Coverage - PR: [apache/shardingsphere#39324](https://github.com/apache/shardingsphere/pull/39324) - Reviewed head: `57a94f38ccb56fe1e15c93f77b8abfefbd8ecf4b` - Base: `303c378e032c25157c01aeb84ef89941d2002d7b` - The GitHub file list matches the local triple-dot scope: 2 files. - Reviewed root cause, boundary states, session continuation, protocol output, conflict paths, test validity, and regression risk. - No unresolved evidence gaps remain. - This conclusion covers code correctness only; CI was not queried or reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
