terrymanu commented on PR #39340: URL: https://github.com/apache/shardingsphere/pull/39340#issuecomment-5182392290
### Result **Review Result: Mergeable** The BLOB fix preserves raw bytes in both MySQL text and binary result paths, with focused success, failure, and stream-cleanup coverage. No current-head blocker remains. ### Evidence - Reviewed head: [`06171bf26cd6`](https://github.com/apache/shardingsphere/commit/06171bf26cd6a8999b1b03aca4a325164964aef8). - Both [text results](https://github.com/apache/shardingsphere/blob/06171bf26cd6a8999b1b03aca4a325164964aef8/database/protocol/dialect/mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacket.java#L72-L103) and [binary results](https://github.com/apache/shardingsphere/blob/06171bf26cd6a8999b1b03aca4a325164964aef8/database/protocol/dialect/mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/packet/command/query/binary/execute/protocol/MySQLByteLenencBinaryProtocolValue.java#L42-L60) serialize `Blob` contents without text conversion and close the stream. - MySQL protocol focused tests: 37 tests, 0 failures/errors; Maven exit 0. - The two round-robin files are byte-identical to current base commit [`cb2a869`](https://github.com/apache/shardingsphere/commit/cb2a869ff57ff66d514397cca571d242c03eb50c) from #39339, so they add no effective merge delta. ### Coverage - All six [GitHub-authoritative files](https://github.com/apache/shardingsphere/pull/39340/files) were accounted for; GitHub compare and local triple-dot scope matched. - Reviewed clusters: BLOB serialization for text/prepared-statement results; upstream-duplicate round-robin changes. - Completed root-cause, blast-radius/contracts, tests/runtime/operations, latest-delta, and full-scope convergence passes. - No linked issue, public comments, reviews, or unresolved evidence gaps. - Code-correctness result only; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
