strongduanmu commented on PR #39356:
URL: https://github.com/apache/shardingsphere/pull/39356#issuecomment-5202480320
• ### Result
**Review Result: Mergeable**
After excluding the Oracle `OR REPLACE` + `IF NOT EXISTS` mutual-exclusion
syntax issue as requested, I found no other code-correctness blockers.
### Evidence
Reviewed local head: `d132b36c6e30f185617126f49d02c5eb121cbd6c`.
Relevant checks previously verified as passing:
- MySQL parser visitor focused test
- MySQL protocol `MySQLComStmtExecutePacketTest`
- Oracle `OracleDDLStatementVisitorTest`
- Oracle parser IT `InternalOracleParserIT`
### Coverage
Covered all 16 changed files in the PR.
Reviewed scope:
- MySQL binary DATE parameter decoding
- MySQL CTAS parameter marker propagation
- Oracle CREATE PACKAGE grammar, visitor, and statement model
- Oracle parser IT JAXB/assert/resource registration
Excluded item: Oracle `CREATE PACKAGE` official mutual-exclusion rule
between `OR REPLACE` and `IF NOT EXISTS`, per the current request.
CI scope: This was a code-correctness review only; CI status was not
rechecked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
