thswlsqls opened a new pull request, #39361:
URL: https://github.com/apache/shardingsphere/pull/39361
Fixes #39359.
Changes proposed in this pull request:
- Collect current mask table names into `CaseInsensitiveSet` in
`CreateMaskRuleExecutor.checkDuplicatedRuleNames()`, so `CREATE MASK RULE
T_ORDER` on an existing `t_order` is rejected as duplicate instead of
persisting a second table node.
- Collect current mask table names into `CaseInsensitiveSet` in
`AlterMaskRuleExecutor.checkToBeAlteredRules()`, so `ALTER MASK RULE T_ORDER`
on an existing `t_order` is no longer rejected as missing.
- Collect altered table names into `CaseInsensitiveSet` in
`AlterMaskRuleExecutor.buildToBeDroppedRuleConfiguration()`, so the altered
table's stale algorithm is dropped instead of staying counted as in use.
- Reuses the idiom already used by `DropMaskRuleExecutor` in the same
module; `MaskRule.tables` is a `CaseInsensitiveMap` and `ShowMaskRuleExecutor`
already matches with `equalsIgnoreCase`, so create and alter were the only
case-sensitive paths left.
- Completes #32755, which made mask show and drop case-insensitive but
left create and alter; #39200 applied the same fix to broadcast.
- Adds one regression test per site; all three fail before this change.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
