terrymanu commented on PR #39390: URL: https://github.com/apache/shardingsphere/pull/39390#issuecomment-5232455707
### Result **Review Result: Mergeable** No blocking code-correctness issues were found at the latest public head. ### Evidence - One-pass charset updates preserve atomic session state, MySQL error semantics, final backend collation replay, and independent client/result/connection character sets. - The obsolete MySQL charset provider has no remaining production caller; its service registration, test, and native-image metadata were removed consistently. - Exception consolidation preserves MySQL vendor code `1231` and its complete message arguments. - Current-source verification passed: 135 tests across six affected test classes, with zero failures. Initial failures were traced to stale pre-head parser and exception artifacts and disappeared with the complete current-source module set. - Reachability metadata remains valid JSON, and repository-wide searches found no remaining references to the removed provider or exception. ### Coverage - Reviewed head: [`ea1450516d3b01ce26438e67d41e9fd214dbbc55`](https://github.com/apache/shardingsphere/commit/ea1450516d3b01ce26438e67d41e9fd214dbbc55). - Scope: all 15 authoritative files from [PR #39390](https://github.com/apache/shardingsphere/pull/39390); GitHub’s list matches the local triple-dot diff from merge-base `8fa7bc08c3839bffd6d75dc071997b2c029bbf24`. - Requirements: the PR’s three stated goals and existing MySQL protocol, session-state, replay, SPI-loading, compatibility, and native-packaging contracts. No linked issue or public review discussion exists. - Behavior clusters completed: exception consolidation; charset lookup simplification; cached replay bookkeeping; one-pass session charset handling; SPI/service/native-metadata removal. - Root-cause, blast-radius/contracts, tests/runtime/operations, latest-delta, and full-scope convergence passes completed with no unresolved gaps. - This is a code-scope result only; CI and GitHub Actions status were not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
