ClaireLytt commented on PR #39093:
URL: https://github.com/apache/shardingsphere/pull/39093#issuecomment-5263707136
@terrymanu
Thank you for your guidence!
for p1, I have added test like
```
<rewrite-assertion
id="update_physical_target_with_table_variable_source_colliding_set_column_for_literals"
db-types="SQLServer">
<input sql="UPDATE HumanResources.Employee SET VacationNote = 'x'
FROM HumanResources.Employee AS e JOIN @MyTableVar ON e.BusinessEntityID =
EmpID" />
<output sql="UPDATE HumanResources.Employee SET
[vacation_note_cipher] = 'encrypt_x' FROM HumanResources.Employee AS e JOIN
@MyTableVar ON e.BusinessEntityID = EmpID" />
</rewrite-assertion>
<rewrite-assertion
id="update_table_variable_colliding_set_column_from_employee_for_literals"
db-types="SQLServer">
<input sql="UPDATE @MyTableVar SET VacationNote = 'annual leave'
FROM HumanResources.Employee AS e WHERE e.BusinessEntityID = EmpID AND
e.VacationNote = 'annual leave'" />
<output sql="UPDATE @MyTableVar SET VacationNote = 'annual leave'
FROM HumanResources.Employee AS e WHERE e.BusinessEntityID = EmpID AND
e.[vacation_note_cipher] = 'encrypt_annual leave'" />
</rewrite-assertion>
for p2,I have refactored the code
Please review again. I'm apreciate the time you spent on this pr!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
