menghaoranss commented on PR #39494: URL: https://github.com/apache/shardingsphere/pull/39494#issuecomment-5313552546
```markdown ### Result **Review Result: Mergeable** The change correctly delegates default-schema resolution to `ShardingSphereDatabase` while preserving explicit-schema precedence, validation, and every refresh branch. ### Evidence - [`RefreshTableMetaDataExecutor`](https://github.com/apache/shardingsphere/blob/8182b64bd4ab1d9e837de9c9ef9fac81aabb3bc0/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/refresh/RefreshTableMetaDataExecutor.java#L46-L90) now uses the database-owned, identifier-aware default schema. - [`ShardingSphereDatabase.getDefaultSchemaName()`](https://github.com/apache/shardingsphere/blob/8182b64bd4ab1d9e837de9c9ef9fac81aabb3bc0/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabase.java#L303-L315) returns the actual matched schema name after protocol normalization. - The tests retain coverage for table, schema, database, storage-unit, missing-schema, and missing-table paths. - Focused verification passed: 13 tests, 0 failures, 0 errors. ### Coverage - Reviewed head: `8182b64bd4ab1d9e837de9c9ef9fac81aabb3bc0`. - All 3 authoritative [changed files](https://github.com/apache/shardingsphere/pull/39494/files) were accounted for; GitHub and local triple-dot inventories matched. - Reviewed cluster: default-schema resolution for `REFRESH TABLE METADATA`, including handler wiring and all reload branches. - Completed root-cause, blast-radius/contracts, tests/runtime, and final convergence passes with no blocking findings or unresolved code-evidence gaps. - This is a code-scope result only; CI was not reviewed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
