menghaoranss commented on PR #39497: URL: https://github.com/apache/shardingsphere/pull/39497#issuecomment-5323324850
```markdown ### Result **Review Result: Mergeable** The change correctly propagates the database-owned default schema into metadata rebuilds while preserving persistence and failure behavior. ### Evidence - [`DatabaseMetaDataPersistFacade`](https://github.com/apache/shardingsphere/blob/7cb0de873820ab99eda3c2c42752cf6158c8a326/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/persist/metadata/DatabaseMetaDataPersistFacade.java#L104-L143) now uses `database.getDefaultSchemaName()` for storage-unit removal and altered-table rebuilding. - [`ShardingSphereDatabase.getDefaultSchemaName()`](https://github.com/apache/shardingsphere/blob/7cb0de873820ab99eda3c2c42752cf6158c8a326/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabase.java#L303-L315) resolves the actual logical schema name through the identifier-aware schema index. - The updated tests assert that the resolved schema is passed into `GenericSchemaBuilderMaterial`; those assertions would fail with the previous registry-derived path. - Focused verification passed: 10 tests, 0 failures, 0 errors. ### Coverage - Reviewed head: `7cb0de873820ab99eda3c2c42752cf6158c8a326`. - All 2 authoritative [changed files](https://github.com/apache/shardingsphere/pull/39497/files) were accounted for; GitHub and local triple-dot inventories matched. - Reviewed cluster: default-schema propagation during metadata persistence and rebuilding. - Standalone and cluster consumers, loader-material semantics, persistence mutations, and SQL-loading failure paths were checked. - Completed root-cause, blast-radius/contracts, tests/runtime, and final convergence passes with no blocking findings or unresolved code-evidence gaps. - This is a code-scope result only; CI was not reviewed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
