terrymanu commented on issue #29816: URL: https://github.com/apache/shardingsphere/issues/29816#issuecomment-5329092642
Hi @Pace2Car, thanks for tracking this. The core part has already landed in master, but I'd keep this issue open until the remaining dialects and tests are done. Already merged: - `TableType` was added to table metadata, and MySQL collection was implemented in #29953, where `MySQLMetaDataLoader` marks views via `information_schema.VIEWS`. - The PostgreSQL, Oracle and OpenGauss loaders now also set `TableType.VIEW` for views on master. Still missing on master: - `H2MetaDataLoader` and `SQLServerMetaDataLoader` still build `TableMetaData` with the constructor that defaults to `TableType.TABLE`, so views are still loaded as tables for these two databases. - The UT/IT item is not covered yet: `MySQLShowTablesExecutorTest#assertShowTablesExecutorWithFull` only asserts the column count, and no test asserts the `Table_type` value returned by `SHOW FULL TABLES`. - Worth aligning at the same time: the proxy renders the enum name, so `SHOW FULL TABLES` returns `TABLE` for base tables while native MySQL returns `BASE TABLE`. So I suggest keeping this issue open with `status: volunteer wanted` for the H2 and SQLServer loaders plus the missing test assertions. Once a PR covering them is merged, we can close this issue as completed. I can tick the finished checklist items in the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
