terrymanu commented on issue #27139: URL: https://github.com/apache/shardingsphere/issues/27139#issuecomment-5329273872
Hi @FlyingZC, thanks for the report. This issue has been completed and can be closed. Oracle `DROP TYPE` parsing was implemented by #27217 (merged into 5.4.1): the `dropType` rule in `parser/sql/engine/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4` covers `DROP TYPE type_name [FORCE | VALIDATE]`, and `OracleDDLStatementVisitor#visitDropType` builds the statement. The Oracle test cases `drop_type`, `drop_type_schema_force` and `drop_type_schema_validate` cover it in `test/it/parser/src/main/resources`. I verified on the current master that all the `DROP TYPE ... FORCE` examples in this issue parse successfully. #27217 referenced #27136 instead of this issue by mistake, which is why it was never closed automatically. The remaining example `CREATE OR REPLACE TYPE ... (NOT INSTANTIABLE MEMBER FUNCTION ...)` is a `CREATE TYPE` statement, out of the scope of this `DROP TYPE` issue; it can be tracked separately under #26878. Closing this issue as completed. #27140 duplicates this one and will be closed as duplicate as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
