terrymanu commented on issue #27132: URL: https://github.com/apache/shardingsphere/issues/27132#issuecomment-5329278572
Hi @FlyingZC, thanks for reporting this. The parsing support listed here is already implemented in current ShardingSphere, so we can close this issue. Verified on the latest master: - `CREATE DATABASE ... DEFAULT TEMPORARY TABLESPACE ...`, `UNDO TABLESPACE ...`, `SET TIME_ZONE = ...` and `DEFAULT TABLESPACE ... DATAFILE ...` are all parsed by the Oracle dialect. The IT cases `create_database_oracle1` / `create_database_oracle2` in `test/it/parser/src/main/resources/sql/supported/ddl/create-database.xml` cover exactly the statements quoted in this issue, and they were added by #13936 back in 2021. The `ALTER DATABASE` variants are covered by `defaultSettingsClauses` in the Oracle grammar. - `SELECT XMLQuery(... RETURNING CONTENT ...)` is supported and covered by the `select_xmlquery_function` IT case. - The `DELETE` / `INSERT` examples with `ROWID` are ordinary DML and parse without issues. - `DEFINE REGION = 'Asia'` is a SQL*Plus client-side substitution-variable command rather than SQL sent to the database server, so it is out of scope for the SQL parser. Closing this as already implemented. If anyone still hits a parsing error with these statements on a recent version, please comment with the exact SQL and version and we will reopen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
