menghaoranss commented on PR #39500: URL: https://github.com/apache/shardingsphere/pull/39500#issuecomment-5336891513
```markdown ### Result **Review Result: Mergeable** The change correctly uses the database metadata owner’s resolved default schema during standalone metadata rebuilds, with focused regression coverage. ### Evidence - [`rebuildDatabaseSchemaIndex`](https://github.com/apache/shardingsphere/blob/9f137456a9e21d215236e60b542694faa61a9535/mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java#L341-L347) now delegates default-schema resolution to `ShardingSphereDatabase#getDefaultSchemaName()`. - [`ShardingSphereDatabase#getDefaultSchemaName()`](https://github.com/apache/shardingsphere/blob/9f137456a9e21d215236e60b542694faa61a9535/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabase.java#L308-L315) preserves the actual matching schema name while retaining the protocol-derived fallback. - The [regression test](https://github.com/apache/shardingsphere/blob/9f137456a9e21d215236e60b542694faa61a9535/mode/type/standalone/core/src/test/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistServiceTest.java#L228-L247) verifies that the rebuilt database contains the resolved default schema. - Focused verification passed: `StandaloneMetaDataManagerPersistServiceTest` — 19 tests, 0 failures, 0 errors, exit code 0. ### Coverage - Reviewed head: `9f137456a9e21d215236e60b542694faa61a9535`. - The authoritative GitHub scope and local triple-dot scope matched: 2 files reviewed. - Reviewed the default-schema-aware standalone metadata rebuild cluster across storage-unit and rule-removal entry paths. - Completed root-cause/behavior, blast-radius/contracts, tests/runtime/operations, and final convergence passes. - No unresolved correctness gaps or blocking issues. - Code-correctness result only; CI was not reviewed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
