menghaoranss commented on PR #39513: URL: https://github.com/apache/shardingsphere/pull/39513#issuecomment-5339062209
```markdown ### Result **Review Result: Mergeable** The checker now resolves the default schema through the database metadata owner while preserving schema-qualified index behavior and providing explicit missing-schema diagnostics. ### Evidence - [`ShardingDropIndexRouteContextChecker`](https://github.com/apache/shardingsphere/blob/2bc89951b2a90a0bb55dfebb8eafbc46a7fe3b65/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/checker/ddl/ShardingDropIndexRouteContextChecker.java#L48-L60) uses `database.findDefaultSchema()` for unqualified indexes and the explicit owner for qualified indexes. - The resolution is consistent with [`SupportedSQLCheckEngine`](https://github.com/apache/shardingsphere/blob/2bc89951b2a90a0bb55dfebb8eafbc46a7fe3b65/infra/checker/src/main/java/org/apache/shardingsphere/infra/checker/SupportedSQLCheckEngine.java#L44-L61). - [Focused tests](https://github.com/apache/shardingsphere/blob/2bc89951b2a90a0bb55dfebb8eafbc46a7fe3b65/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/checker/ddl/ShardingDropIndexRouteContextCheckerTest.java#L71-L135) cover successful and rejected routes, absent default schemas, and missing explicitly named schemas. - Focused verification passed: `ShardingDropIndexRouteContextCheckerTest` — 4 tests, 0 failures, 0 errors, exit code 0. ### Coverage - Reviewed head: `2bc89951b2a90a0bb55dfebb8eafbc46a7fe3b65`. - Merge base: `9b777f016fd6b89d75a030b855087831aff43383`. - The authoritative GitHub scope and local triple-dot scope matched: 2 files reviewed. - Reviewed the default-schema-aware `DROP INDEX` route-validation cluster, including PostgreSQL-focused tests, qualified and unqualified indexes, validation-bypass reachability, exception behavior, and metadata ownership. - Completed root-cause/behavior, blast-radius/contracts, tests/runtime/operations, and final convergence passes. - No unresolved correctness gaps or blocking issues. - Code-correctness result only; CI was not reviewed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
