sandynz commented on PR #39514:
URL: https://github.com/apache/shardingsphere/pull/39514#issuecomment-5339139298
### Result
**Review Result: Mergeable**
The latest commit closes both findings from the previous review, and the
complete integrated range has no remaining code-correctness blockers.
### Evidence
- `SingleDataNodeRuleAttributeTest.java:56-59` now directly verifies the
concrete Single rule attribute’s storage-origin contract.
- `SchemaMetaDataUtilsTest.java:144-168` covers both metadata-check states
for:
- preserving storage-discovered identifier case;
- normalizing configuration-derived identifiers.
- `DataNodes.java:70-87` resolves identifier provenance from the same
first matching rule attribute used to obtain the data nodes.
- `DataNodeRuleAttribute.java:47-54` retains backward compatibility
through a default `false` implementation, while
`SingleDataNodeRuleAttribute.java:56-59` activates the storage-loaded
behavior.
- `SchemaMetaDataUtils.java:67-75,120-157` consistently applies the
provenance decision to enabled, disabled, and fallback metadata-loading paths.
- Current-source verification passed:
- `DataNodesTest`: exit 0.
- `SchemaMetaDataUtilsTest`: exit 0.
- `SingleDataNodeRuleAttributeTest`: exit 0.
- Scoped Spotless check: exit 0.
- Scoped Checkstyle check: exit 0.
- IDE build of all seven changed files: successful.
- IDE error-level inspection: no findings.
### Coverage
- Reviewed range: `c27f7988232..7bc1a39241f`, including `6fa28c7c2bf` and
primarily reviewing `7bc1a39241f`.
- Range freshness: current `HEAD`; worktree clean.
- Files accounted for: all seven changed production and test files.
- Behavior clusters reviewed:
- data-node identifier provenance;
- Single rule activation;
- cross-protocol metadata identifier normalization;
- metadata-check enabled and disabled paths;
- fallback, same-database-type, and mixed-storage behavior.
- Completed discovery lenses: root cause and behavior, blast radius and
contracts, tests/runtime/operations, and final convergence.
- Phase A: all checks passed.
- Phase B: no significant completeness, correctness, or coherence issues.
- Unresolved evidence gaps: none for code correctness.
- This is a code-scope result only; CI and GitHub Actions were not
reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
